sound: extend CI checks

[mewmew]

Add GolangCI meta linter among others.

Code coverage token will be added in a follow-up PR.

[wsc1]

I added ci_checks.sh to meta

[wsc1]

LGTM

[wsc1]

sorry, didn't mean to close

[wsc1]

why revert ci_checks script?

[mewmew]

why?

I couldn't get code coverage reporting to work with the token you sent, so had to update and trouble shoot the ci_checks script. And I don't have access to zc/meta as far as I know.

[wsc1]

Github tells me you have admin access on all zc repos.

[mewmew]

Oh well, we can live without code coverage reporting for now. I tried to trouble shoot why the COVERALLS_TOKEN is not set by travis, but couldn't figure it out. Without this token, this branch is never taken:

if [ "${COVERALLS_TOKEN}" ]; then
	echo "### go tool cover"
	go test -covermode=count -coverprofile=coverage.out ./...
	go tool cover -func coverage.out

	# To submit the test coverage result to coveralls.io use goveralls
	# (https://github.com/mattn/goveralls)
	goveralls -coverprofile coverage.out -service travis-ci -repotoken ${COVERALLS_TOKEN}
fi

[mewmew]

Github tells me you have admin access on all zc repos.

Oh, that's more than I know. I thought I was only part of ext.

[mewmew]

Feel free to merge this and then the COVERALLS_TOKEN issue can be trouble shot later.

got to go.

Cheers,
/u

[wsc1]

Since we've got so many CI build issues, maybe I'll clean up the various more cosmetic issues from these new CI checks in the repo first...

[wsc1]

Looking more closely, it seems the linter is checking whether error return values are checked?

I don't like that; for example, when using sndbuf there are no io errors but it has them to fit the interface. Is there some way to refine the linter checks or the files on which they operate? Don't want to lose a badge over something like that :(

[wsc1]

any ideas on how to make travis recognise stdatomic.h via cgo?

[mewmew]

It should work with newer versions of GCC, as suggested in cmus/cmus#604

If there is something specific to Cgo that prevents it from working, I don't know.