Upgrade cgltf to v1.15 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazeycode
reviewed
Dec 28, 2025
| extern fn cgltf_node_transform_world(node: ?*const Node, out_matrix: ?*[16]f32) void; | ||
|
|
||
| extern fn cgltf_buffer_view_data(view: ?*const BufferView) ?[*]u8; | ||
| extern fn cgltf_find_accessor(prim: ?*const Primitive, type: AttributeType, index: i32) ?*const Accessor; |
Member
There was a problem hiding this comment.
For proper CABI compatibility index should really be of type c_int, as cgltf_int is defined as int in cgltf.h. There's loads of incorrect integer types already so this is at least in-keeping with the status quo. I'll follow up with fixes.
Contributor
Author
There was a problem hiding this comment.
Right, I used i32 based on what I saw in the rest of zcgltf.zig. I can adress those if you want.
Member
There was a problem hiding this comment.
Great, if you'd like to take care of it while you're working on the lib it would be much appreciated. Otherwise it might take some time before I get to it because it doesn't seem to be an issue that is affecting anyone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #14 and enable the use of webp extension (among other features).