perf: jtop: not encode zero value #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
fynb |
vizee
reviewed
Dec 29, 2020
| } | ||
|
|
||
| func (e *Encoder) transString(token *Token, field *metadata.Field) { | ||
| if len(token.Value) == 2 { |
Contributor
There was a problem hiding this comment.
transString 不能只通过判断空字符串跳过，在 {"a": ["", "", ""]} 情况下，假设 a 的 tag 为 1，应该返回 [10, 0, 10, 0, 10, 0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not encode zero value
if a JSON object contains fields with zero value (such as
"",0,null,[])jtop will not encode those fields to protobuf anymore.