Skip to content

Comments

Add compat symlinks for original zendframework layout#144

Draft
glensc wants to merge 1 commit intozf1s:masterfrom
glensc:symlink-compat
Draft

Add compat symlinks for original zendframework layout#144
glensc wants to merge 1 commit intozf1s:masterfrom
glensc:symlink-compat

Conversation

@glensc
Copy link
Contributor

@glensc glensc commented Nov 15, 2022

This allows easier patching and syncing with zf1 future:

In zf1-future repo:

  1. Extract patch from the other repo: git format-patch -1 COMMIT

In zf1s repo:

  1. switch to this branch git checkout symlink-compat
  2. create new branch: git checkout -b zf1-future/asdf
  3. and apply the patch file git am 0001-something.patch
  4. rebase without the symlinks commit git rebase -i origin/master

an alternative would be to use cherry-pick:

  1. git remote add zf1-future https://github.com/Shardj/zf1-future
  2. git fetch zf1-future
  3. git cherry-pick COMMIT

This allows easier patching and syncing with zf1 future
@glensc
Copy link
Contributor Author

glensc commented Nov 15, 2022

This is not intended for merging, but rather for setting up a workspace. But may be useful for merging too. Dunno.

@partikus
Copy link
Contributor

@glensc did you consider to prepare a php script for creating symlinks of legacy layout? e.g. composer create-symlinks sounds interesting and then we could keep it in the repo

@glensc
Copy link
Contributor Author

glensc commented Jan 17, 2023

@partikus no I did not consider it:

are the symlinks even necessary?

why do you want the symlinks? if there's a use case, perhaps it's just worth merging.

@partikus
Copy link
Contributor

TBH I do not need them at all ;) I've written that question with losing context about Shardj/zf1-future. Did you update description or I've overlooked it? Does not matter. Anyway, thank you for responding.

@glensc
Copy link
Contributor Author

glensc commented Jan 17, 2023

yes. I edited:

image

but that's why I used it, there may be other use cases, like using zf1s/zf1 as monorepo insallation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants