feat: Allow searching users by email #2510
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables searching for users by their email addresses in addition to existing name-based search functionality. The changes also refactor the AccountsInput component to use internal state with React's useDeferredValue hook for improved search performance by reducing unnecessary re-renders during typing.
- Added email search capability to the user filtering logic
- Refactored AccountsInput component to manage its own internal state and use useDeferredValue for performance optimization
- Removed redundant search prop passing throughout the component tree
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/instances/[zuid]/users.js | Enhanced user filtering logic to include email search alongside name search |
| src/components/accounts/ui/input/AccountsInput.js | Refactored to use internal state and useDeferredValue for better performance |
| src/views/accounts/instances/Users.js | Removed redundant search prop from component interface |
| src/views/accounts/instances/Settings.js | Removed redundant search prop from AccountsInput usage |
| src/views/accounts/instances/Apis.js | Removed redundant search prop from AccountsInput usage |
| src/pages/instances/[zuid]/support/index.js | Removed redundant search prop from AccountsInput usage |
| src/components/globals/constants.js | Fixed missing comma in object literal |
agalin920
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #
Type of change
Please delete options that are not relevant.
Screenshots / Screen recording
zesty-pw.webm