Skip to content

[aes_gcm] Fix typo causing AES-GCM timing test to fail#194

Merged
pqcfox merged 1 commit intomasterfrom
kat/fix-aes-gcm-timing-test
Feb 6, 2026
Merged

[aes_gcm] Fix typo causing AES-GCM timing test to fail#194
pqcfox merged 1 commit intomasterfrom
kat/fix-aes-gcm-timing-test

Conversation

@pqcfox
Copy link
Contributor

@pqcfox pqcfox commented Feb 5, 2026

This PR fixes one line in aes_gcm_timing_test to properly initialize the result variable. Before, result was completely uninitialized, causing the test to fail even though all OTTF test runs passed.

Signed-off-by: Kat Fox <kat@zerorisc.com>
@pqcfox pqcfox requested a review from jadephilipoom February 5, 2026 14:56
Copy link
Collaborator

@jadephilipoom jadephilipoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@pqcfox
Copy link
Contributor Author

pqcfox commented Feb 6, 2026

Both test failures unrelated, merging.

@pqcfox pqcfox merged commit 8a58c51 into master Feb 6, 2026
26 of 28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants