Draft
Conversation
These tests were flaky in the CI, because they push right up against the 1500s 'long' timeout. Signed-off-by: Ryan Torok <rtorok@zerorisc.com>
Adjusts the duty cycle tolerance in the pwm_smoketest to accept values within one percentage point of the expected value instead of 1% of the value. This prevents the test from becoming stricter for smaller duty cycles. For example, a test with a 10% duty cycle should accept between 9-11% duty, not 9.9-10.1%. Signed-off-by: Ryan Torok <rtorok@zerorisc.com>
rtorok-zr
force-pushed
the
flaky-fpga-tests
branch
from
4cefeaa to
e8010ab
Compare
pqcfox
approved these changes
Feb 5, 2026
Contributor
pqcfox
left a comment
pqcfox
left a comment
There was a problem hiding this comment.
LGTM, modulo the lint check ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a working PR for updating various FPGA tests to make them less flaky in CI.