[noup] zephyr: add support for nan#119
Open
Qingling-Wu wants to merge 2 commits intozephyrproject-rtos:mainfrom
Open
[noup] zephyr: add support for nan#119Qingling-Wu wants to merge 2 commits intozephyrproject-rtos:mainfrom
Qingling-Wu wants to merge 2 commits intozephyrproject-rtos:mainfrom
Conversation
01c61a8 to
566596c
Compare
krish2718
reviewed
Jan 30, 2026
Comment on lines
+669
to
+678
| #if CONFIG_WIFI_NM_WPA_SUPPLICANT_NAN | ||
| struct wpa_supplicant *wpa_s = if_ctx->supp_if_ctx; | ||
|
|
||
| if (wpa_s && is_nan_sdf_frame(frame, len)) | ||
| { | ||
| wpa_printf(MSG_DEBUG, "NAN: Sending EVENT_TX_WAIT_EXPIRE"); | ||
| wpa_supplicant_event_wrapper(if_ctx->supp_if_ctx, | ||
| EVENT_TX_WAIT_EXPIRE, | ||
| NULL); | ||
| } |
Collaborator
There was a problem hiding this comment.
can you please do this in a separate commit that provides context in the commit log?
Implement NAN Service Discovery Frame detection in the Zephyr WiFi driver to support WiFi Aware functionality. - Add is_nan_sdf_frame() to identify NAN SDF frames - Generate EVENT_TX_WAIT_EXPIRE for NAN SDF TX completion - Enable proper NAN discovery flow in Zephyr environment Signed-off-by: Qingling Wu <qingling.wu@nxp.com>
Add NAN Unsynchronized Service Discovery (USD) initialization - Call wpas_nan_usd_init() during interface initialization Signed-off-by: Qingling Wu <qingling.wu@nxp.com>
566596c to
34aa8af
Compare
jukkar
reviewed
Feb 10, 2026
| u32 vendor_type = 0; | ||
|
|
||
| /* Minimum length: MAC header (24) + Category (1) + PA (1) + OUI+Type (4) */ | ||
| if (len < 30) |
Member
There was a problem hiding this comment.
Could you follow the coding style used in the other parts of this file.
if (len < 30) {
....
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.