I fixed the slowness issue, and made the tetrominoes a little bigger. I did have to convert line endings, which I did in one commit.#1
Open
frank-murphy wants to merge 4 commits intozenzoa:mainfrom
Conversation
Owner
|
Cool! I like the look of a lot of your changes, but I'm not sure how you made the tetrominoes bigger while still getting them to fit in the same area... I'll have to a look at it in the simulator when I have the chance! Also, what was the slowness issue? |
Author
|
When I sent minoSize to 12, the Gfx.setClipRect uses that to calculate the size of the board, so the board “just grew.” Basically, there’s no more gap above or below the board anymore.
The slowness came from believing that the millisecond timer could actually do all the drawing in a millisecond. It couldn’t, so added a 50 ms lag. Not a big deal at level one, but a big impact by level 3. Instead, I set the timer to be a fixed 10 ms and move the tetronimo down more than one row if the G value calls for it. It took me a while to figure out what was going wrong!
… On Oct 3, 2023, at 9:18 PM, SG ***@***.***> wrote:
Cool! I like the look of a lot of your changes, but I'm not sure how you made the tetrominoes bigger while still getting them to fit in the same area... I'll have to a look at it in the simulator when I have the chance!
Also, what was the slowness issue?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Owner
|
I'm happy to merge in your other fixes, but I'd prefer to keep the original visuals. Do you mind separating them out into two different pull requests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.