Skip to content

Fix json parse error when not using json #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jonatino wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix json parse error when not using json #16

jonatino wants to merge 1 commit into from

Conversation

@jonatino
Copy link

@jonatino jonatino commented Jun 16, 2025 •
edited
Loading

Imo this action shouldn't assume the value is json, just return the text and allow the user to parse json if they're expecting it.

Eg I have a key with a value of

assets_checksum=605d14e4162af0fca0b26411c5aa2b584504d4b04a168a617777689ec681949b
assets_url=https://cdn.legendsoftaria.com/assets.zip

This breaks this action with this error

Getting value for config_properties
Error: Unexpected token 'a', "assets_che"... is not valid JSON

@jonatino
Fix json parse error when not using json
109b3f5 
This shouldn't assume the value is json, just return the text and allow the user to parse json if they're expecting it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonatino