[tbc-ge] fix deposit interest payout error #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test cases for deposit statements that properly handle: - Interest payouts (interestedAmount) - Withdrawals (withdrawnDepositAmount) - Combined deposits and interest - Regular deposits These tests currently fail because convertStatementV2 only uses depositAmount and ignores interestedAmount and withdrawnDepositAmount, causing transactions with sum=0 when depositAmount=0.
…drawals Fix convertStatementV2 to properly handle all deposit statement types: - Interest payouts (interestedAmount) - Withdrawals (withdrawnDepositAmount) - Regular deposits (depositAmount) Based on observed API behavior, only one field is non-zero at a time (mutually exclusive), so use if/else logic. Add descriptive comments to help ZenMoney categorize transactions. Previously only depositAmount was used, causing transactions with sum=0 when interest was paid out (depositAmount=0, interestedAmount>0), which resulted in "Wrong transaction. Transaction should have either income > 0 or outcome > 0" errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors while synchronization like
[TSZ] Wrong transaction ODIwNDAyOTEzOjA6MTc2MDA0MDAwMDAwMA==. Transaction should have either income > 0 or outcome > 0Now consider
interestedAmountandwithdrawnDepositAmountfromDepositStatementV2, too