[vakifbank-tr] fix Blob.arrayBuffer() compatibility for XLSX parsing #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add blobToArrayBuffer() helper function with multiple fallback strategies to support environments where Blob.prototype.arrayBuffer() is not available. The function tries: 1. Native blob.arrayBuffer() method 2. ZenMoney.Blob polyfill's _getBytes() if blob is already wrapped 3. Wrapping native Blob with ZenMoney.Blob and using _getBytes() This fixes XLSX file import failures on devices running older versions of the Zenmoney app where the breaking change in commit 01f30a6 caused native Blob objects to be returned without the arrayBuffer() polyfill.
Contributor
Author
Member
|
@AmirL Hi! Maybe the native blobs function .bytes() => Promise can help? It's supported in the new native blob format. We'll restore .arrayBuffer() in the next application release as well. |
Contributor
Author
Don't know. I didn't test it on a real device, but I hope that the PR can fix it anyway. Do you mind merging it? |
Contributor
Author
|
Hi @skvav Would you mind merging it? |
Member
|
@AmirL This bug with Blob will be fixed in the next app release in several days. Please wait and we'll check it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
XLSX file import fails on some devices with error:
aei[cTZ(0x33ad)] is not a functionThe plugin works fine in dev mode but fails on actual devices.
Solution
Add
blobToArrayBuffer()helper with fallback strategies for environments whereBlob.prototype.arrayBuffer()may not be available:blob.arrayBuffer()_getBytes()Includes logging to help diagnose which path is used.