[kaspi] deposit parsing and kaspi gold fixes #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action handling logic - Implement tests for `dropOffsettingSinglesSameAccount`, `dropPlaceholderTransfers`, and `mergeSinglesIntoSelfTransfers` to ensure correct transaction filtering and merging behavior. - Introduce new utility functions for better transaction normalization and account handling. - Refactor transaction processing logic to improve clarity and maintainability, including enhancements to account key generation and transaction signature handling. - Update the `parsePdfStatements` function to accommodate new transaction structures and ensure accurate parsing of deposit statements. - Modify transaction converters to support additional transaction types and improve merchant detection logic.
Removed error detail extraction from reply payload and updated reply target to use event.target.
- Updated deposit transaction tests to include new scenarios and corrected descriptions. - Improved regex patterns for parsing deposit details and transaction descriptions. - Added functionality to extract deposit contract numbers from statements. - Enhanced transaction type detection for transfers to Kaspi deposits and other accounts. - Refactored transaction parsing logic to handle various transaction formats and descriptions more robustly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Здесь добавлен и отремонтирован парсинг депозитов Каспи + при переводах с/на депозиты делаем корректную транзакцию + при переводах кому-то/от кого-то считаем это расходом, а не как перевод