Add logo in center field in live football games#458
Closed
mamamia5x wants to merge 38 commits intozengm-games:field-and-drivefrom
Closed
Add logo in center field in live football games#458mamamia5x wants to merge 38 commits intozengm-games:field-and-drivefrom
mamamia5x wants to merge 38 commits intozengm-games:field-and-drivefrom
Conversation
Member
|
Very cool! I thought about doing this myself but I decided it might look too busy. I'll leave this PR open in case I reconsider. For now, I still have a ways to go on the basic functionality of the new feature. |
Contributor
Author
|
It's looking good so far. |
…s/punts/turnovers
… the interception one can go in the main play popover and the return can be in a sub-play
…ms always going left to right
… is messed up if you change it during the season
Contributor
Author
|
Just updated the code to fit the current build, just have to resolve some conflicts. I changed the image size to fit around 10 yards in the center. |
mamamia5x
force-pushed
the
scoreboard
branch
from
dcc9cdf to
e206ae3
Compare
Up to date
Contributor
Author
|
#459 is the updated branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was tinkering around and came up with a way to show the logo. Here is how they currently look.
I'm not that good with TS, so it took me a bit to figure things out.
Notes:
Please let me know if you have any questions or if there is anything else I can do to this.