Skip to content

added the player trading card#447

Open
ItamarTati wants to merge 1 commit intozengm-games:masterfrom
ItamarTati:player_trading_card
Open

added the player trading card#447
ItamarTati wants to merge 1 commit intozengm-games:masterfrom
ItamarTati:player_trading_card

Conversation

@ItamarTati
Copy link
Copy Markdown

I need some help with when it should and shouldn't render, how do I determine who is a legend.

And Also where should the card be

@dumbmatter
Copy link
Copy Markdown
Member

dumbmatter commented May 18, 2023

Thanks! Looks like a good start, I will probably merge it and mess around with it.

Sorry for not mentioning before, but can you make sure you're okay with the license and sign the CLA? https://github.com/zengm-games/zengm/tree/master#license-and-contributor-license-agreement

@ItamarTati
Copy link
Copy Markdown
Author

Thanks! Looks like a good start, I will probably merge it and mess around with it.

Sorry for not mentioning before, but can you make sure you're okay with the license and sign the CLA? https://github.com/zengm-games/zengm/tree/master#license-and-contributor-license-agreement

I sent an email agreeing to the terms and explaining my current situation.

If you need any help merging it in feel free to message me :)

@ItamarTati
Copy link
Copy Markdown
Author

@dumbmatter do you still want to merge this in, do you need any help?

@dumbmatter dumbmatter force-pushed the master branch 2 times, most recently from 59d4a13 to 665f9ad Compare January 19, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants