Open
Conversation
dumbmatter
requested changes
Aug 21, 2022
Member
dumbmatter
left a comment
dumbmatter
left a comment
There was a problem hiding this comment.
For late game stuff, see where forceThreePointer is used, that logic should change a bit here.
| this.elamActive = false; | ||
| this.elamDone = false; | ||
| this.elamTarget = 0; | ||
| this.isOneTwos = isOneTwos; |
Member
There was a problem hiding this comment.
Add a new setting to defaultGameAttributes.ts and then you can just access it here with g.get("isOnesTwos"), similar to other settings used in this file like numPlayersOnCourt. Also in defaultGameAttributes.ts add the new setting to gameAttributesKeysSportSpecific (might require merging with master) so it's not included in other sports exports.
Member
|
For TS% I think it's probably not worth changing, because someone might change this setting in the middle of a season and then who knows what anything means. |
dumbmatter
force-pushed
the
master
branch
2 times, most recently
from
59d4a13 to
665f9ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything looks correct. Lookin g into the engine a bit to see what changes people should do.
Things to consider changing