Open
Conversation
Member
|
This is really cool, thanks! I will probably not merge this until I have a use for it in BBGM (which I probably should at some point, would be fun to have a GM character you can make for yourself, or maybe a coach). Cause until then it's just increasing the file size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a real use case for this right now, but figured I would offer it up as a 'jersey' option. This PR adds in 2 new jerseys, 'suit' and 'suit2'. I thought maybe a suit would make sense if you ever include owners, coaches, GMs, or whatever. Or perhaps it would look good on free agents or retired players.
I added logic to remove a player's headband, facemask, glasses, etc if they're wearing a suit. With the first suit option, the player's tie will be solid in the team's primary color. Suit2 has primary color tie, with white and secondary color stripes.
Below are examples for both, tested in my local editor.html yarn run. Please note - when testing this I got a javascript error stating 'variable faces does not exist' on line 787 of editor.html, but upon re-starting yarn the error disappeared. Not sure if that is a real issue.