Skip to content
This repository was archived by the owner on May 16, 2018. It is now read-only.

Problem with module in upper#687

Open
emiliodeg wants to merge 1 commit intozendframework:masterfrom
emiliodeg:patch-4
Open

Problem with module in upper#687
emiliodeg wants to merge 1 commit intozendframework:masterfrom
emiliodeg:patch-4

Conversation

@emiliodeg
Copy link
Copy Markdown

With a default router /:module/:controller/:action/:params all works fine. But for example in URL request

/MODULE/controller/action (module in upper) get error Notice: Undefined index: MODULE in \vendor\zendframework\zendframework1\library\Zend\Controller\Dispatcher\Standard.php on line 397

In $controllerDirs all key are in lowercase

Other solution modify the Request Abstract Class

abstract class Zend_Controller_Request_Abstract {

/**
     * Retrieve the module name
     *
     * @return string
     */
    public function getModuleName()
    {
        if (null === $this->_module) {
            $this->setModuleName($this->getParam($this->getModuleKey()));
        }

        return $this->_module;
    }

    /**
     * Set the module name to use
     *
     * @param string $value
     * @return Zend_Controller_Request_Abstract
     */
    public function setModuleName($value)
    {
        $this->_module = strtolower($value);
        return $this;
    }
}

With a default router /:module/:controller/:action/:params all works fine. But for example in URL request

/MODULE/controller/action (module in upper) get error Notice: Undefined index: MODULE in \vendor\zendframework\zendframework1\library\Zend\Controller\Dispatcher\Standard.php on line 397

In $controllerDirs all key are in lowercase

Other solution modify the Request Abstract Class

```php

abstract class Zend_Controller_Request_Abstract {

/**
     * Retrieve the module name
     *
     * @return string
     */
    public function getModuleName()
    {
        if (null === $this->_module) {
            $this->setModuleName($this->getParam($this->getModuleKey()));
        }

        return $this->_module;
    }

    /**
     * Set the module name to use
     *
     * @param string $value
     * @return Zend_Controller_Request_Abstract
     */
    public function setModuleName($value)
    {
        $this->_module = strtolower($value);
        return $this;
    }
}

```
@emiliodeg
Copy link
Copy Markdown
Author

Well sorry I test in linux and the solution is modify Zend_Controller_Request_Abstract

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants