Refactor and Enhance Card Game Logic and UI#7
Open
mahirabidi12 wants to merge 4 commits intozendalona:masterfrom
Open
Refactor and Enhance Card Game Logic and UI#7mahirabidi12 wants to merge 4 commits intozendalona:masterfrom
mahirabidi12 wants to merge 4 commits intozendalona:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the card game codebase, enhancing functionality, accessibility, and performance.
Deck Management Improvements
Enhanced the Deck class for better card shuffling using the Fisher-Yates algorithm.
Improved Card class structure for better readability and maintainability.
Fixed the typo in the socket event (STO1C-DRAW-CARDS → STOC-DRAW-CARDS).
Optimized the partitioning function to handle card distribution more effectively.
Implemented a delayedCode function to emit partitioned cards to connected clients after a 2-second delay.
Bug Fixes and Error Handling
Fixed socket error handling for better user experience.
Improved handling of DOM node insertion and dynamic event binding.