-
-
Notifications
You must be signed in to change notification settings - Fork 37
Fixed SingleBuffer backend data corruption issue
#277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
james-pre
merged 5 commits into
zen-fs:main
from
lvcabral:fix-data-corruption-single-buffer
Nov 6, 2025
Merged
Fixed SingleBuffer backend data corruption issue
#277
james-pre
merged 5 commits into
zen-fs:main
from
lvcabral:fix-data-corruption-single-buffer
Nov 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-pre
reviewed
Nov 6, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow thanks for fixing this! I have a couple small suggestions regarding code style, but otherwise everything looks good.
james-pre
reviewed
Nov 6, 2025
Co-authored-by: James Prevett <jp@jamespre.dev>
Co-authored-by: James Prevett <jp@jamespre.dev>
Co-authored-by: James Prevett <jp@jamespre.dev>
james-pre
approved these changes
Nov 6, 2025
Member
james-pre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at https://github.com/orgs/zen-fs/discussions/276 there was a data corruption issue with the
SingleBufferbackend, this PR fixes it, and adds a reliability test case