Skip to content

fix: add preference gate for macOS dock progress to preserve Tahoe icon style #12877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baton-noir wants to merge 1 commit into from
+20 −0
Closed

fix: add preference gate for macOS dock progress to preserve Tahoe icon style #12877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/browser/components/downloads/DownloadsTaskbar-sys-mjs.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
diff --git a/browser/components/downloads/DownloadsTaskbar.sys.mjs b/browser/components/downloads/DownloadsTaskbar.sys.mjs
--- a/browser/components/downloads/DownloadsTaskbar.sys.mjs
+++ b/browser/components/downloads/DownloadsTaskbar.sys.mjs
@@ -140,6 +140,16 @@
(!aForcedBackend && gInterfaces.macTaskbarProgress)
) {
// On Mac OS X, we have to register the global indicator only once.
+ // Skip if dock progress is disabled (workaround for macOS Tahoe
+ // Clear icon style reverting to coloured). See Bug 1997246.
+ if (
+ !Services.prefs.getBoolPref(
+ "browser.taskbar.dockProgress.enabled",
+ true
+ )
+ ) {
+ return;
+ }
this.#taskbarProgresses.add(gInterfaces.macTaskbarProgress);
// Free the XPCOM reference on shutdown, to prevent detecting a leak.
Services.obs.addObserver(() => {