Skip to content

Fix Og Title Overflow #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saboonikhil merged 3 commits into from
Feb 26, 2025
Merged

Fix Og Title Overflow #2480

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
488440d
Debug overflow
saboonikhil Feb 25, 2025
ec98308
Do not resize font
saboonikhil Feb 25, 2025
ec0924b
Maintain the original font sizing
saboonikhil Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions pages/api/og/generate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ export default async function GenerateOgImage(request: NextRequest) {
new URL("../../../public/og/zeitgeist_badge.png", import.meta.url),
).then((res) => res.arrayBuffer()),
]);

const image = (
<div
tw="px-16 pt-16 pb-24 text-white"
Expand Down Expand Up @@ -100,9 +101,22 @@ export default async function GenerateOgImage(request: NextRequest) {
src={cmsImageUrl ?? fallbackImagePath}
tw="rounded-[5px]"
/>
<h1 tw={`${questionClass} ml-6`} style={{ lineHeight: "1.3em" }}>
<div
tw={`ml-6 font-bold ${questionClass}`}
style={{
maxWidth: '800px',
display: 'flex',
flexDirection: 'column',
lineHeight: 1.3,
wordBreak: 'break-word',
overflow: 'hidden',
textOverflow: 'ellipsis',
WebkitLineClamp: 3,
WebkitBoxOrient: 'vertical'
}}
>
{question}
</h1>
</div>
</div>
<div tw="flex flex-col mt-10">
<h2 tw={`font-bold text-4xl font-sans`}>
Expand All @@ -115,8 +129,8 @@ export default async function GenerateOgImage(request: NextRequest) {
? market.marketType.categorical
? `${prediction.name} (${prediction.percentage}%)`
: `${Intl.NumberFormat("en-US", {
maximumSignificantDigits: 3,
}).format(Number(prediction.name))}`
maximumSignificantDigits: 3,
}).format(Number(prediction.name))}`
: "No Prediction"}
</div>
</div>
Expand Down
Loading