Speed up test suite: 160s → 44s #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Session-scoped app fixture (no per-test create_app) - JSON fixture for pre-computed article/NLP data (skips Stanza pipeline) - Wordstats mock (avoids loading 400k WordInfo objects) - Fix: check tokenization cache before loading Stanza in get_tokenized_content() - Remove unused hardcoded feeds from FeedRule (3 extra feeds per BookmarkRule) - Consolidate article tests (4→1), bookmark tests (18→3) - Delete redundant slow tests (feed download, Article.find_or_create) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
ArchLens - No architecturally relevant changes to the existing views |
- Move cache_on_data_keys decorator to core/utils/caching.py - Move feature toggle logic to core/user_feature_toggles.py - Create core/test/test_app.py for minimal test Flask app - Create core/test/fixtures.py for shared test fixtures - Add BookmarkValidationError exception to update_bookmark.py - Change search_subscription to raise ValueError instead of HTTP response - Remove unused make_error import from feedback_component.py The core module no longer imports from api, eliminating the circular dependency pattern. Test infrastructure now uses a minimal Flask app that doesn't require the full API. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move FleschKincaidDifficultyEstimator import inside _get_estimators() so that nltk and scipy are only loaded when difficulty estimation is actually needed, not at module import time. This cuts test startup time by ~1.5 seconds. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move the test fixture regeneration code from core/test/_session_data.py to tools/regenerate_test_fixture.py. This removes the last core→api import, as the regeneration script legitimately needs the full API but doesn't belong in the core module. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Jan 28, 2026
- Simplify run_tests.sh to just run pytest - Remove pytest-testmon from requirements.txt - Delete docs/SMART_TESTS.md and run_tests_full.sh - Clean up .gitignore entries for testmon data files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WordInfo/LanguageInfoobjects avoid loading 400k entries from disk (~12s savings)article.get_tokenized_content()loaded Stanza tokenizer before checking the cache — now checks cache first and returns immediately on hitFeedRule(was creating 3 extra feeds perBookmarkRuleinvocation)Article.find_or_createtests, duplicatetest_create_articleTest plan
🤖 Generated with Claude Code