fix: upgrade core-graphics to 0.25 for core-text 21.1.0 compatibility#6
Open
noeljackson wants to merge 1 commit intozed-industries:masterfrom
Open
fix: upgrade core-graphics to 0.25 for core-text 21.1.0 compatibility#6noeljackson wants to merge 1 commit intozed-industries:masterfrom
noeljackson wants to merge 1 commit intozed-industries:masterfrom
Conversation
core-text 21.1.0 (released 2026-01-15) upgraded its core-graphics dependency from 0.24 to 0.25. This caused build failures when font-kit was used as a dependency because it still specified core-graphics 0.24, resulting in two incompatible versions of core-graphics in the dependency tree. The symptom was type mismatches like: expected `core_graphics::font::CGFont`, found a different `core_graphics::font::CGFont` This commit upgrades core-graphics to 0.25 to match core-text's requirement. Fixes: zed-industries/zed#47168
noeljackson
added a commit
to noeljackson/gpui-ce
that referenced
this pull request
Feb 3, 2026
core-text 21.1.0 (released 2026-01-15) upgraded its core-graphics dependency from 0.24 to 0.25. This caused build failures because gpui-ce still specified core-graphics 0.24, resulting in two incompatible versions of core-graphics in the dependency tree. Also updated font-kit reference to use a fixed fork with the same fix. Related: zed-industries/zed#47168 Related: zed-industries/font-kit#6
noeljackson
added a commit
to noeljackson/gpui-ce
that referenced
this pull request
Feb 3, 2026
core-text 21.1.0 (released 2026-01-15) upgraded its core-graphics dependency from 0.24 to 0.25. This caused build failures because gpui-ce still specified core-graphics 0.24, resulting in two incompatible versions of core-graphics in the dependency tree. Also updated font-kit reference to use a fixed fork with the same fix. Related: zed-industries/zed#47168 Related: zed-industries/font-kit#6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core-text 21.1.0 (released 2026-01-15) upgraded its core-graphics dependency from 0.24 to 0.25. This caused build failures when font-kit was used as a dependency because it still specified core-graphics 0.24, resulting in two incompatible versions of core-graphics in the dependency tree.
Problem
The symptom was type mismatches like:
This is because Rust treats types from different versions of the same crate as distinct types.
Solution
Upgrade core-graphics from 0.24 to 0.25 to match what core-text 21.1.0 requires.
Testing
Tested by building a project that depends on gpui-ce, which uses zed-font-kit. Build succeeds with this fix.
Fixes: zed-industries/zed#47168