Merged
Conversation
- Filter out JAVA_HOME and PATH from base environment before setting - Determine single JAVA_HOME value based on precedence rules - Set JAVA_HOME and PATH only once to avoid conflicts - Ensures service-level JAVA_HOME properly overrides profile-level setting This fixes the issue where both profile and service JAVA_HOME appeared in environment variables, causing the first (wrong) one to be used.
- Change verbose flag insertion to replace wrapper command instead of goal - Add -X flag right after ./mvnw for Maven (not after spring-boot:run) - Add -i flag right after ./gradlew for Gradle (not after bootRun) - Works correctly regardless of whether javaOpts are present This fixes the issue where verbose flags weren't being added to the command because the string replacement was looking for a pattern that didn't match when javaOpts were present. Example output: - Before: cd /path && ./mvnw spring-boot:run - After: cd /path && ./mvnw -X spring-boot:run
Fixed three critical issues preventing the verbose logging checkbox from persisting: - Added VerboseLogging field to ServiceConfigRequest model - Updated frontend payload to include verboseLogging when saving services - Fixed loadDynamicServices to load verbose_logging column from database The verbose logging feature now works end-to-end: 1. User checks "Enable verbose logging" checkbox 2. Value is sent in save payload to backend 3. Backend saves to database 4. Value is loaded when services are fetched 5. Checkbox shows correct state when reopening service config 6. Maven services run with -X flag, Gradle services with -i flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.