Skip to content

fix: resolve asdf and SDKMAN Java shims to actual installation paths #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Dec 1, 2025
Merged

fix: resolve asdf and SDKMAN Java shims to actual installation paths #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion internal/services/java_env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,18 @@ func DetectJavaEnvironment() *JavaEnvironment {

// Method 1: Check JAVA_HOME environment variable
if javaHome := os.Getenv("JAVA_HOME"); javaHome != "" {
// Check if JAVA_HOME points to asdf shims directory and resolve it
if strings.Contains(javaHome, "/.asdf/shims") {
log.Printf("[DEBUG] JAVA_HOME points to asdf shims, attempting to resolve: %s", javaHome)
// Try to resolve using asdf
cmd := exec.Command("asdf", "which", "java")
if output, err := cmd.Output(); err == nil && len(output) > 0 {
realJavaPath := strings.TrimSpace(string(output))
javaHome = inferJavaHome(realJavaPath)
log.Printf("[DEBUG] Resolved JAVA_HOME from asdf to: %s", javaHome)
}
}

javaPath := filepath.Join(javaHome, "bin", getJavaExecutable())
if isExecutable(javaPath) && isWorkingJava(javaPath) {
env.JavaHome = javaHome
Expand Down Expand Up @@ -198,7 +210,40 @@ func isWorkingJava(javaPath string) bool {
}

func inferJavaHome(javaPath string) string {
// Remove /bin/java to get JAVA_HOME
// Check if this is an asdf shim and resolve it to the real Java path
if strings.Contains(javaPath, "/.asdf/shims/") {
log.Printf("[DEBUG] Detected asdf shim, attempting to resolve actual Java path: %s", javaPath)

// Try to use 'asdf which java' to get the real path
cmd := exec.Command("asdf", "which", "java")
if output, err := cmd.Output(); err == nil && len(output) > 0 {
realJavaPath := strings.TrimSpace(string(output))
log.Printf("[DEBUG] Resolved asdf shim to: %s", realJavaPath)
// Use the real Java path for inference
binDir := filepath.Dir(realJavaPath)
if filepath.Base(binDir) == "bin" {
resolvedHome := filepath.Dir(binDir)
log.Printf("[DEBUG] Inferred JAVA_HOME from resolved path: %s", resolvedHome)
return resolvedHome
}
} else {
log.Printf("[WARN] Failed to resolve asdf shim: %v", err)
}
}

// Check if this is an SDKMAN installation and use the current symlink
if strings.Contains(javaPath, "/.sdkman/candidates/java/") && strings.Contains(javaPath, "/current/") {
log.Printf("[DEBUG] Detected SDKMAN Java installation: %s", javaPath)
// For SDKMAN, we can use the path as-is since 'current' is already resolved
binDir := filepath.Dir(javaPath)
if filepath.Base(binDir) == "bin" {
resolvedHome := filepath.Dir(binDir)
log.Printf("[DEBUG] Using SDKMAN Java home: %s", resolvedHome)
return resolvedHome
}
}

// Standard inference: Remove /bin/java to get JAVA_HOME
binDir := filepath.Dir(javaPath)
if filepath.Base(binDir) == "bin" {
return filepath.Dir(binDir)
Expand Down