Open
Conversation
str4d
reviewed
Dec 19, 2025
turbocrime
reviewed
Jan 7, 2026
Comment on lines
+86
to
+98
| if params.is_regtest() { | ||
| match self { | ||
| Servers::Custom(servers) => return Ok(servers.first().expect("not empty")), | ||
| Servers::Hosted(op) => { | ||
| return Err(anyhow!( | ||
| "Regtest network requires a custom server.\n\ | ||
| Use: --server localhost:9067 (or your lightwalletd address)\n\ | ||
| Hosted servers ({:?}) only support mainnet and testnet.", | ||
| op | ||
| )) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
would be nice to default to localhost and/or allow config from file or env
Collaborator
|
Looks like this ended up highly conflicted with the SOCKS proxy PR that was just merged. |
Author
thanks for reply. will look into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds improved support for Regtest. Currently hardcodes upgrade heights to 1, but could be updated to allow customizable upgrade heights.