Fix GetTreeState to follow Orchard SkipHash independently#549
Open
zmanian wants to merge 1 commit intozcash:masterfrom
Open
Fix GetTreeState to follow Orchard SkipHash independently#549zmanian wants to merge 1 commit intozcash:masterfrom
zmanian wants to merge 1 commit intozcash:masterfrom
Conversation
The GetTreeState handler followed only the Sapling SkipHash chain to find a block with Sapling FinalState, then returned whatever Orchard state happened to be at that same block. Since Sapling and Orchard have independent SkipHash chains, the Sapling ancestor block often lacks Orchard FinalState, causing GetTreeState to return an empty OrchardTree for post-NU5 blocks. Now, after finding Sapling FinalState, if Orchard FinalState is missing, we restart from the originally requested block and follow Orchard's own SkipHash chain. Pre-NU5 blocks correctly return an empty OrchardTree since no Orchard SkipHash exists. Also fixes a pre-existing "cannot marshal" typo (should be "cannot unmarshal") and adds an iteration bound to both SkipHash loops to guard against infinite loops from malformed zcashd responses. Fixes zcash#438 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
zmanian
force-pushed
the
fix-gettreestate-orchard
branch
from
8f685c3 to
c00fa1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orchardTreefor post-NU5 blocksCloses #438
Test plan
go build ./...passesgo vet ./frontend/...passessaplingTreeandorchardTreeare populatedorchardTreeis empty (expected)Generated with Claude Code