Upgrade protobuf/gRPC toolchain and regenerate proto files#544
Merged
LarryRuane merged 1 commit intozcash:masterfrom Feb 25, 2026
Merged
Conversation
czarcas7ic
commented
Feb 3, 2026
Comment on lines
-146
to
-153
| # Update your protoc, protobufs, grpc, .pb.go files | ||
| update-grpc: | ||
| go get -u google.golang.org/protobuf | ||
| go get -u google.golang.org/grpc | ||
| cd walletrpc && protoc --go_out=. --go_opt=paths=source_relative --go-grpc_out=. --go-grpc_opt=paths=source_relative service.proto | ||
| cd walletrpc && protoc --go_out=. --go_opt=paths=source_relative --go-grpc_out=. --go-grpc_opt=paths=source_relative darkside.proto | ||
| cd walletrpc && protoc --go_out=. --go_opt=paths=source_relative --go-grpc_out=. --go-grpc_opt=paths=source_relative compact_formats.proto | ||
| go mod tidy |
Contributor
Author
There was a problem hiding this comment.
make proto does this now
| google.golang.org/grpc v1.61.0 | ||
| google.golang.org/protobuf v1.33.0 | ||
| golang.org/x/exp v0.0.0-20230905200255-921286631fa9 | ||
| google.golang.org/grpc v1.78.0 |
Contributor
Author
There was a problem hiding this comment.
This is the core of the fix
LarryRuane
reviewed
Feb 3, 2026
Collaborator
LarryRuane
left a comment
LarryRuane
left a comment
There was a problem hiding this comment.
Thanks for doing this! Tested, works for me. One small suggestion below.
scripts/regenerate-protos.sh
Outdated
|
|
||
| for proto in "${PROTOS[@]}"; do | ||
| echo " ${proto}" | ||
| cd "${REPO_ROOT}/walletrpc" && protoc \ |
Collaborator
There was a problem hiding this comment.
REPO_ROOT, which is somewhat hard to understand, can be eliminated by putting around the cd and everything that follows (to the end of line 22).
Contributor
Author
There was a problem hiding this comment.
Addressed here, thanks
Contributor
Author
|
NP, thanks for quick review! |
LarryRuane
reviewed
Feb 3, 2026
Collaborator
LarryRuane
left a comment
LarryRuane
left a comment
There was a problem hiding this comment.
ACK, please squash to one commit, thanks.
czarcas7ic
force-pushed
the
adam/upgrade-protobuf-grpc-toolchain
branch
from
4600ece to
e35baf7
Compare
Contributor
Author
|
@LarryRuane pinging to make sure you are tracking that it has been squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pb.gofiles with the latest protoc toolchain (protoc v33.2,protoc-gen-go v1.36.11,protoc-gen-go-grpc v1.6.0)google.golang.org/grpcfrom v1.61.0 to v1.78.0 to satisfy the newSupportPackageIsVersion9requirementgoogle.golang.org/protobuffrom v1.33.0 to v1.36.10scripts/regenerate-protos.shandmake prototarget for proto regenerationContext
Installing the latest protoc toolchain and regenerating the proto files produces code that requires gRPC-Go v1.64.0+, causing compile failures against the previously pinned grpc v1.61.0.
The old generated code used
protoc-gen-go-grpc v1.3.0/protoc v4.25.2which emittedSupportPackageIsVersion7. The new toolchain emitsSupportPackageIsVersion9and uses newer streaming types (grpc.ServerStreamingClient,grpc.ServerStreamingServer) that only exist in grpc-go v1.64.0+.Error prior to change that no longer occurs after this PR: