use getblock verbose=3 instead of two getblock calls#449
Open
LarryRuane wants to merge 1 commit intozcash:masterfrom
Open
use getblock verbose=3 instead of two getblock calls#449LarryRuane wants to merge 1 commit intozcash:masterfrom
LarryRuane wants to merge 1 commit intozcash:masterfrom
Conversation
This was referenced Aug 9, 2023
88dd1ef to
09c3fea
Compare
If available, use `getblock verbose=3`. If not available, use the old way, which requires making two `getblock` RPCs. This is only a performance improvement.
09c3fea to
23f1889
Compare
Collaborator
Author
|
Force-pushed rebase, then another (23f1889) to implement a performance improvement for the case that
The whole idea of this PR is to improve performance; we don't want to make it worse in a (temporarily) common situation. With this force-push, This code can be removed when the last |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If available, use
getblock verbose=3. If not available, use the old way, which requires making twogetblockRPCs. This is only a performance improvement.After the EOL of the latest version that doesn't support verbose=3, this code can be simplified to only do the verbose=3 form (since it will be guaranteed to be implemented in zcashd).
This still needs a unit test, but seeking a concept and approach ACKs first.
See also #392 and corresponding PR zcash/zcash#6747. These PRs can be merged and deployed in either order.