-
Notifications
You must be signed in to change notification settings - Fork 3
Add black and pre-commit hook #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 943 943
=========================================
Hits 943 943 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Additional changes introduced:
|
annakasprzik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- I guess we have seen the warning about check/scan before.
Yes, for the time being the deprecation warning coming from |
Relevant issue: #104
Background info:
# any relevant background info for additional context, references to documentations etc.stwfsapy. We have decided to opt forblack.pre-commithooks should be added tostwfsapy.Changes introduced:
# list changes to the code repo made in this pull requestblackandpre-commithave been added as dev dependencies inside thepyproject.tomlfile.pre-commitconfig file has been added. It contains hooks forblackandruff.ruffhas been bumped to the version being used inside the.pre-commit.config.yamlfile.poetry.lockfile has been updated, respectively to reflect the new packages and dependencies.stephas been added inside one of our github workflow files. More specifically, we run a code formatting check inside the.github/workflows/ci.ymlfile.README.mdfile has included a badge for Black. Furthermore, some comments have been added in the Contribute section.