Skip to content

Conversation

@gmmajal
Copy link
Contributor

@gmmajal gmmajal commented Dec 11, 2025

Relevant issue: #74

Background info: # any relevant background info for additional context, references to documentations etc.

  • Newer versions of Black, pre-commit and Ruff are available. We should update the versions of these packages.
  • Additional linting rules should be inserted for Ruff.
  • Ruff pre-commit hook should be added to assist the development workflow.

Changes introduced: # list changes to the code repo made in this pull request

  • The new linting rules have been added inside the pyproject.toml file. Furthermore, the versions of Ruff, Black and pre-commit have been bumped.
  • A new poetry.lock file has been generated.
  • Ruff has been added inside the .pre-commit-config.yaml file.
  • The scripts have been modified to satisfy the newly added linting rules. Most of the changes are associated with the ordering of the modules imported (Isort based rules).

@gmmajal gmmajal self-assigned this Dec 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (564d9c3) to head (fb0decd).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #75   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          905       906    +1     
=========================================
+ Hits           905       906    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmmajal
Copy link
Contributor Author

gmmajal commented Dec 11, 2025

Additional changes:

  • Some empty spaces inside the test_cli.py script had to be removed in order to satisfy our code formatter.

@gmmajal gmmajal marked this pull request as ready for review December 11, 2025 12:43
@gmmajal gmmajal requested a review from annakasprzik December 11, 2025 12:43
Copy link
Contributor

@annakasprzik annakasprzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the checks, didn't see any issues

@gmmajal gmmajal merged commit dbdb73c into zbw:master Dec 11, 2025
5 checks passed
@gmmajal gmmajal deleted the 74-update-black-and-ruff branch December 12, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants