Extensible CompressorFactory registry.#23
Open
pedson wants to merge 2 commits intozarr-developers:mainfrom
Open
Extensible CompressorFactory registry.#23pedson wants to merge 2 commits intozarr-developers:mainfrom
pedson wants to merge 2 commits intozarr-developers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on PR #10 with a small modification to allow a compressor implementation to be replaced, in addition to adding additional compressor ids. There are situations where it makes sense to swap out a built-in compressor implementation, such as blosc.
Minor related changes:
CompressorFactoryto return the supported compressor ids and the implementations associated with each id.