Skip to content

use classic checksum for diagnostic frames, fixes #30 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yannik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use classic checksum for diagnostic frames, fixes #30 #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion injector/src_reference/arduino/lin_frame.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@

// Compute the checksum of the frame. For now using LIN checksum V2 only.
uint8 LinFrame::computeChecksum() const {
// diagnostic frames always use classic checksum
const boolean diagnostic = ((bytes_[0] & 0x3f) == 0x3c || (bytes_[0] & 0x3f) == 0x3d) ? true : false;
// LIN V2 checksum includes the ID byte, V1 does not.
const uint8 startByteIndex = custom_defs::kUseLinChecksumVersion2 ? 0 : 1;
const uint8 startByteIndex = (custom_defs::kUseLinChecksumVersion2 && !diagnostic) ? 0 : 1;
const uint8* p = &bytes_[startByteIndex];

// Exclude the checksum byte at the end of the frame.
Expand Down