Publish version after SnapStart config update during zappa update#1450
Merged
Publish version after SnapStart config update during zappa update#1450
Conversation
…1448) During `zappa update`, the version was published before SnapStart was enabled in the config. Since SnapStart only snapshots versions published after enablement, the latest version never got a snapshot. Fix by publishing an additional version after updating the configuration when snap_start is enabled, and updating the ALB alias if present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zappa update, the version was published before SnapStart was enabled in the config, so SnapStart never created a snapshot for the latest versionsnap_startenabled, publishes an additional version to trigger SnapStart snapshot creationTest plan
test_snap_start_publishes_version_after_config_update— verifiespublish_versionis called when snap_start is enabledtest_snap_start_disabled_does_not_publish_extra_version— verifies no extra publish when snap_start is disabledtest_snap_start_updates_alb_alias_after_publish— verifies ALB alias is updated to point to the new version