Skip to content

Comments

Truncate pubkey in Lightning invoice creation logs#185

Merged
spe1020 merged 2 commits intofeature/membership-rings-and-baseline-fixesfrom
copilot/sub-pr-183-again
Feb 17, 2026
Merged

Truncate pubkey in Lightning invoice creation logs#185
spe1020 merged 2 commits intofeature/membership-rings-and-baseline-fixesfrom
copilot/sub-pr-183-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 17, 2026

Addresses privacy feedback from #183: the full 64-character pubkey was being logged in the Lightning invoice creation endpoint, enabling potential user correlation in production logs.

Changed log statement to truncate pubkey to 16-character prefix:

console.log('[Membership Lightning] Invoice created:', {
  receiveRequestId,
  amountSats,
  tier,
  period,
  pubkey: pubkey.substring(0, 16) + '...',  // was: pubkey
});

This follows the established pattern used in 50+ other locations throughout the codebase for logging user identifiers.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: spe1020 <140115230+spe1020@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 17, 2026

Deploying frontend with  Cloudflare Pages  Cloudflare Pages

Latest commit: bdf8d01
Status: ✅  Deploy successful!
Preview URL: https://c7d8d4b9.frontend-hvd.pages.dev
Branch Preview URL: https://copilot-sub-pr-183-again.frontend-hvd.pages.dev

View logs

Copilot AI changed the title [WIP] Update membership rings and baseline fixes in Lightning KV store Truncate pubkey in Lightning invoice creation logs Feb 17, 2026
Copilot AI requested a review from spe1020 February 17, 2026 17:31
@spe1020 spe1020 marked this pull request as ready for review February 17, 2026 17:39
@spe1020 spe1020 merged commit 49205da into feature/membership-rings-and-baseline-fixes Feb 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants