allow setting of secret description#134
Open
chippyash wants to merge 2 commits intozalando:masterfrom
Open
Conversation
Signed-off-by: Ashley Kitson <ashley.kitson@zinc.systems>
szuecs
reviewed
Jan 5, 2026
| } | ||
|
|
||
| func TestSetDescription(t *testing.T) { | ||
| if runtime.GOOS != "windows" && runtime.GOOS != "darwin" { |
Member
There was a problem hiding this comment.
IMO switch case would be more readable
szuecs
reviewed
Jan 5, 2026
| type secretServiceProvider struct{} | ||
|
|
||
| // secretDescription holds a user set secret description | ||
| var secretDescription string |
Member
There was a problem hiding this comment.
this should be a member of the secretServiceProvider
szuecs
reviewed
Jan 5, 2026
| var secretDescription string | ||
|
|
||
| // SetDescription sets the description of the secret | ||
| func (s secretServiceProvider) SetDescription(description string) { |
Member
There was a problem hiding this comment.
this will likely need to be a pointer receiver, if we have it as member
szuecs
reviewed
Jan 5, 2026
|
|
||
| // SetDescription sets the description of the secret | ||
| func (k windowsKeychain) SetDescription(description string) { | ||
| //no-op for windows |
Member
There was a problem hiding this comment.
why should we have a comment here but not in the others?
szuecs
requested changes
Jan 5, 2026
Member
szuecs
left a comment
szuecs
left a comment
There was a problem hiding this comment.
thanks for the PR, from code pov I would say it needs some changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows developers to set the description of the secret being stored. Only useful for gnome-keyring based distributions but nevertheless important for users of those systems.