FUND-423 バリエーション対応したAPIに関する説明を追記 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doi-shuhei-2024
commented
Dec 17, 2025
| + quantity_auto_conversion_by_unit_name: `箱` (string) - 単位換算後の単位名 | ||
| + quantity_auto_conversion_by_unit_factor: `12` (string) - 単位換算係数 | ||
|
|
||
| ### InventoryCreateParams(InventoryUpdateParams) |
Contributor
Author
There was a problem hiding this comment.
メモ）在庫データの新規作成と更新のパラメータはもともと同じ定義（InventoryCreateParams）を参照してました。今回新規作成のほうだけバリエーションに対応しているので、共通部分はInventoryUpdateParamsとして、InventoryCreateParamsは共通部分を継承しつつ、バリエーションのパラメータを個別に追加する形式にしました。
doi-shuhei-2024
commented
Dec 17, 2025
|
|
||
| ### InventoriesIndexViews(InventoriesViews) | ||
|
|
||
| ### InventoriesShowViews(InventoriesViews) |
Contributor
Author
There was a problem hiding this comment.
メモ）在庫データの一覧取得と個別取得でもともと同じ定義（InventoriesViews）を参照してました。今回両方にバリエーション設定項目のデータを追加しています。また、個別取得のほうにはバリエーション一覧のデータも追加しています。共通部分はInventoriesViewsとして、一覧取得をInventoriesIndexViews、個別取得をInventoriesShowViewsとしました。
doi-shuhei-2024
commented
Dec 17, 2025
| font-size: 12px; | ||
| font-weight: normal; | ||
| } | ||
| </style> |
Contributor
Author
There was a problem hiding this comment.
メモ）バリエーション対応のラベル用クラスです。
yutonishi
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景・課題
Jira: https://zaicozaico.atlassian.net/browse/FUND-423
いくつかの公開APIをバリエーションに対応させたので、それらに関する説明を追記しています。
対象API
関連
対応概要
UI変更
その他