Skip to content

[MINIMAL FIX] Enable ADB Keyboard only if not enabled before switching #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodePokemon-p wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MINIMAL FIX] Enable ADB Keyboard only if not enabled before switching #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions phone_agent/adb/input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,21 +72,28 @@ def detect_and_set_adb_keyboard(device_id: str | None = None) -> str:
text=True,
)
current_ime = (result.stdout + result.stderr).strip()

# Switch to ADB Keyboard if not already set
if "com.android.adbkeyboard/.AdbIME" not in current_ime:
subprocess.run(
adb_prefix + ["shell", "ime", "set", "com.android.adbkeyboard/.AdbIME"],
capture_output=True,
text=True,
)

# Get the list of enabled IMEs
ime_list = [
line.strip()
for line in run_shell(adb_prefix + ["shell", "ime", "list", "-s"]).split("\n")
if line.strip()
]
# Enable ADB Keyboard if not already enabled
if "com.android.adbkeyboard/.AdbIME" not in ime_list:
run_shell(adb_prefix + ["shell", "ime", "enable", "com.android.adbkeyboard/.AdbIME"])
# Set the input method
run_shell(adb_prefix + ["shell", "ime", "set", "com.android.adbkeyboard/.AdbIME"])

# Warm up the keyboard
type_text("", device_id)

return current_ime





def restore_keyboard(ime: str, device_id: str | None = None) -> None:
"""
Restore the original keyboard IME.
Expand Down