Skip to content

Conversation

@tigerjibo
Copy link

…ation

Contribution Guide

We welcome your contributions to this repository. To ensure elegant code style and better code quality, we have prepared
the following contribution guidelines.

What We Accept

  • This PR fixes a typo or improves the documentation (if this is the case, you may skip the other checks).
  • This PR fixes a specific issue — please reference the issue number in the PR description. Make sure your code strictly
    follows the coding standards below.
  • This PR introduces a new feature — please clearly explain the necessity and implementation of the feature. Make sure
    your code strictly follows the coding standards below.

Code Style Guide

Good code style is an art. We have prepared a pre-commit hook to enforce consistent code
formatting across the project. You can clean up your code following the steps below:

pre-commit run --all-files

If your code complies with the standards, you should not see any errors.

Naming Conventions

  • Please use English for naming; do not use Pinyin or other languages. All comments should also be in English.
  • Follow PEP8 naming conventions strictly, and use underscores to separate words. Avoid meaningless names such as
    a, b, c.

For glmv-reward Contributors

Before PR, Please run:

cd glmv-reward/
uv sync
uv run poe lint
uv run poe typecheck

@tigerjibo
Copy link
Author

security: replace eval-based parse_action with JSON parsing and validation
Fix: replace unsafe eval-based parsing with JSON + AST parsing

tigerjibo added 9 commits December 15, 2025 11:36
- Remove remote temp screenshot file /sdcard/tmp.png after pull to avoid filling device storage
- Normalize empty/invalid IME values to None in detect_and_set_adb_keyboard()
- Only attempt IME restoration when original_ime is valid (non-empty)
- Wrap keyboard operations in try/except for best-effort error handling
- Both operations now gracefully handle failures without raising to caller
… path

- Keep JSON-first parsing from fix/parse-action-json (security + robustness)
- Add Type/Type_Name fast path from main branch (performance optimization)
- Fallback to full AST parsing if Type fast path fails
- All pathways include debug logging for troubleshooting
- Use modern type annotations (str | None, float | None)
- Integrate TIMING_CONFIG for delay management in device.py
- Add logging, time tracking, and config validation in client.py
- Support streaming with performance metrics (time_to_first_token, time_to_thinking_end, total_time)
- Maintain security validation (__post_init__) for ModelConfig
- Add lang field for i18n support
Updated 系统设计文档/01_概要设计文档.md with latest project information and architecture details.
@tigerjibo
Copy link
Author

增加系统设计文档和概要设计文档

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant