Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 10: Docstrings audit on helpers/indicators.py
Added docstrings to 11 undocumented functions across 4 grouped commits. No logic, formatting, imports, or parameter changes — docstrings only.
Commits:
SMA/EMA crossover functions (sma_crossover_logic, ema_crossover_spy_only, ema_crossover_vix_only)
RSI and MACD functions (rsi_logic, macd_crossover_logic, macd_rsi_filter_logic)
Bollinger, Stochastic, ROC functions (bollinger_breakout_logic, stochastic_logic, roc_logic)
MA bounce and overnight functions (ma_bounce_logic, weekday_overnight_logic)
Updated CLAUDE.md to clarify do-not-touch applies to logic only, not documentation
All 563 existing tests pass. The 14 failures in test_progress_tracking.py are a pre-existing ZeroDivisionError (elapsed time = 0 on fast machines) unrelated to this PR.