feat: add skip_all command#113
Conversation
lib/mneme/terminal.ex
Outdated
| [tag("y", :green), " ", tag("yes", :faint)], | ||
| [tag("n", :red), " ", tag("no", :faint)], | ||
| [tag("s", :yellow), " ", tag("skip", :faint)], | ||
| [tag("x", :red), " ", tag("skip all", :faint)], |
There was a problem hiding this comment.
Two thoughts about this:
- I think this should use
:yellowinstead of:red, since it's more akin tosthann. - While the issue tracking this feature suggested
x(because I was original thinking of it as a sort of "exit"), I'm now wondering if it should useSinstead.
Thoughts?
There was a problem hiding this comment.
Yes, since it's a "more powerful" skip I think it's better if we use S instead of x and it's more in tune with the yellow color.
|
Would you be willing to take a crack at an integration test for this? You can look at |
84ffc7d to
b5dce74
Compare
New integration tests are automatically picked up and run. There's no way to run just a single integration test, but you can run only the integration tests with |
Ok, if I understood correctly besed on the |
|
Just wanted to let you know that this is still on my radar and I'm hoping to do a quick final review, merge, and release later this week. Thanks for being patient! |
|
No worries at all, totally understood that you were busy. Thanks! |
8c864c3 to
6eabd39
Compare
|
I integrated the commented changes with a rebase. The three commits should be updated. |
Co-authored-by: Zach Allaun <zach.allaun@gmail.com>
Co-authored-by: Zach Allaun <zach.allaun@gmail.com>
6eabd39 to
29900d6
Compare
|
Any updates? |

#88 Adds the ability to skip all the tests using the "x" command.