Skip to content

Making checkId compatible with PHP 7.1 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulovitorbal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Making checkId compatible with PHP 7.1 #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions library/Zend/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,11 @@ public static function start($options = false)
*/
protected static function _checkId($id)
{
//In PHP7.1 the session.hash_bits_per_character is deprecated. So this check don't make sense anymore.
// check it out https://wiki.php.net/rfc/session-id-without-hashing
if (version_compare(phpversion(), '7.1.0', '>')) {
return true;
}
$saveHandler = ini_get('session.save_handler');
if ($saveHandler == 'cluster') { // Zend Server SC, validate only after last dash
$dashPos = strrpos($id, '-');
Expand Down