feat: add disc26-29 fixtures (MS IGLOO series)#28
Merged
Conversation
Batch-add 4 disc fixtures from MS IGLOO: - disc26 (D1): 3 episodes, 15 specials — individual OVA playlists + commentary + extras - disc27 (D2): 3 episodes, 15 specials — individual OVA playlists + commentary + extras - disc28 (D3): 3 episodes, 13 specials — MS IGLOO 2, creditless + extras - disc29 (SD): 1 episode (44min OVA), 3 digital archives 453 tests passing across 29 disc fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
yxbh
force-pushed
the
feat/disc26-29-ms-igloo
branch
from
b734fdc to
0d6030a
Compare
Two structural fixes to _detect_special_features(): 1. All-episodes-page detection: extend chapter_selection_jt to include JumpTitle values from IG pages where ALL button targets resolve to episode playlists. Previously only single-JT pages were recognized, causing buttons on multi-episode selection pages (disc8, disc26-28) to be falsely flagged as commentary. 2. Navigation playlist filtering: enhance _nav_playlists_from_hints() to follow one level of JumpTitle indirection from first_playback MO. Disc intros (e.g. 00001.mpls on disc26-28) played via first_playback → JumpTitle → MO → PlayPl chain are now correctly identified as navigation playlists and excluded from title-hint supplementation. Also adds obj_jump_titles to MO hints for JumpTitle chain resolution. Affected disc counts: - disc8: 3 → 1 specials (removed 2 false commentary) - disc26: 15 → 12 specials (removed 2 false commentary + 1 bumper) - disc27: 15 → 12 specials (removed 2 false commentary + 1 bumper) - disc28: 13 → 10 specials (removed 2 false commentary + 1 bumper) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch-add 4 disc fixtures + fix false commentary and bumper detection.
Disc Fixtures
Analysis Fixes
All-episodes-page detection
Extended
chapter_selection_jtto include JumpTitle values from IG pages where ALL button targets resolve to episode playlists. Previously only single-JT pages were recognized, causing buttons on multi-episode selection pages to be falsely flagged as commentary.Navigation playlist filtering
Enhanced
_nav_playlists_from_hints()to follow one level of JumpTitle indirection from first_playback MovieObject. Disc intro playlists (played via first_playback -> JumpTitle -> MO -> PlayPl chain) are now correctly identified as navigation playlists and excluded from title-hint supplementation. Addedobj_jump_titlesto MO hints.Affected disc counts
Test Results
452 tests passing across 29 disc fixtures.