feat: add disc22-25 fixtures + improve periodicity detection#27
Merged
Conversation
New skill for processing multiple Blu-ray ISOs in one pass: - Mount and analyze all ISOs in a folder - Generate summary report with IG menu cross-checks - User reviews/confirms counts in bulk - Create all fixtures, tests, and matrix entries Includes reference batch-analysis-report.py script template for structured report generation with IG button-per-page cross-validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Batch-add 4 disc fixtures from 0083 Stardust Memory: - disc22 (D1): 5 episodes, 0 specials — chapter-split compilation - disc23 (D2): 5 episodes, 0 specials — chapter-split compilation - disc24 (D3): 3 episodes, 8 specials — compilation + commentary + extras - disc25 (SD): 1 episode, 1 digital archive Analysis improvements: - Extended periodicity detector: OP can be at position [1] when [0] is a short preamble; ED check extended to [-3] for patterns with trailing preview/transition chapters after ED - Majority rule: replaced 75% threshold with simple majority (matched > unmatched AND matched >= 2). Series finales often drop OP/ED, making one group fail without invalidating the pattern. - Always try chapter-splitting the longest episode playlist, not just when there's exactly one. Structural evidence (periodicity/IG marks) prevents false splits. 399 tests passing across 25 disc fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch-add 4 disc fixtures + analysis improvements.
Disc Fixtures
Analysis Improvements
Extended periodicity detector
These discs have a 6-chapter-per-episode pattern (OP/BODY/BODY/ED/PREVIEW/TRANSITION) that the previous detector didn't handle:
group[1]whengroup[0]is a short non-OP chapter.group[-3]for ED-range chapters.matched * 2 > n_groups AND matched >= 2. This is a structural criterion (simple majority) rather than a magic number. disc24's 3rd episode (series finale) drops OP/ED — 2/3 groups match, which passes majority but failed at 75%.Always try chapter-splitting the longest playlist
Previously, chapter splitting was only attempted when there was exactly one individual episode playlist. Now it always tries the longest playlist. For disc24, this correctly splits the 86min compilation into 3 ~28min episodes instead of treating it as one giant episode alongside commentary tracks.
Periodicity scores across all fixtures confirm no false positives:
Test Results
399 tests passing (was 348, +51 new tests from 4 fixtures + 24 matrix entries).