Fix diagnostics when visiting JDT provided files #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the URI used to refer to a JDT provided file to the one that was used to generate it in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking around to see what's missing to get eglot to behave more like lsp-mode when visiting files generated from
java/classFileContents.eclipse-jdtls/eclipse.jdt.ls#3423
eclipse-jdtls/eclipse.jdt.ls#2322 (comment)
It turns out that all that's necessary to get proper diagnostics is to refer to a generated file by its original
jdt://URI in all subsequent communications. We already store the URI in a companion.metadatafile, all that's missing is to read it out whenever eglot asks for the file's URI.lsp-javadoes this by settinglsp-buffer-uri.https://github.com/emacs-lsp/lsp-java/blob/9230a0007c79a661028c142f35c7b8d1f9f55453/lsp-java.el#L1451