Skip to content

Slim3 Support WIP#11

Open
Raistlfiren wants to merge 14 commits intoyusukezzz:masterfrom
Raistlfiren:slim3
Open

Slim3 Support WIP#11
Raistlfiren wants to merge 14 commits intoyusukezzz:masterfrom
Raistlfiren:slim3

Conversation

@Raistlfiren
Copy link
Copy Markdown

I am adding this as a placeholder PR in support for Slim 3. There is still quiet a bit to do with this PR like testing and checking if things work...

@NigelGreenway
Copy link
Copy Markdown

@Raistlfiren @yusukezzz Any chance this could be updated? I have cloned and tested within Slim3 and works well. Don't mind picking up the slack on this if required?

@Raistlfiren
Copy link
Copy Markdown
Author

@NigelGreenway This should work for the most part. I think tests are the only thing that need to be fixed. I had a discussion with a few others and they have wrote middleware for PHP Debugbar or Tracy. Although, I don't see the code anywhere on Github. Hmmm...

@NigelGreenway
Copy link
Copy Markdown

Sorry, I haven't worked with it for the last week as on another project.

Everything worked fine from what I remember but I know there was an issue where I changed something locally. Will rebuild demo app from scratch again to test next week.

@tflight
Copy link
Copy Markdown

tflight commented Feb 9, 2017

There is also Tracy Debugger Bar for Slim Framework if that is what you were looking for @Raistlfiren.

@Raistlfiren
Copy link
Copy Markdown
Author

@tflight Oh, you did submit your code. I didn't realize it was a part of the official repository :) 👍

@tflight
Copy link
Copy Markdown

tflight commented Feb 9, 2017

That isn't mine, just throwing it out there for ideas/comparison.

@NigelGreenway
Copy link
Copy Markdown

@tflight have you got it working? can't get the profiler displaying? 😕

@tflight
Copy link
Copy Markdown

tflight commented Feb 9, 2017

@NigelGreenway I haven't tried it. Back when @runcmf was working on it I had been working on something similar for myself. What I had done met my needs so I kept using it. (I do have the Twig Profiler working in my own implementation.)

@NigelGreenway
Copy link
Copy Markdown

No worries @tflight. I have raised an issue on the repo. Confused if I need to call a function in Twig? followed the guide but feel's like I am doing something stupid? 😕

@NigelGreenway
Copy link
Copy Markdown

@tflight sorted it. I was being stupid...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants