Skip to content

Conversation

@Yushi0618
Copy link

πŸ“¦ Pull Request Template

Thank you for your contribution! Please complete the checklist and provide relevant details below to help us review your PR effectively.


πŸ“‹ Summary


πŸ§ͺ Related Issues


βœ… Checklist

  • My code follows the project's coding style
  • I have tested the changes and verified that they work
  • I have added necessary documentation (if applicable)
  • I have linked related issues above (if any)
  • The PR is made from a feature branch, not main

🧠 Additional Context (Optional)


@Edlison
Copy link
Collaborator

Edlison commented Jul 9, 2025

Thanks for your work on this!

To keep things consistent with the PyGIP framework, you should place all your implementation files under the pygip/models/defense directory. You can either organize everything into a single .py file or use a dedicated subfolder as a module.

Also, please structure your experiments using a class that inherits from the DefenseBase base class. Each experiment should be encapsulated as a class method for clarity and modularity.

Feel free to continue updating your code, and don’t hesitate to reach out if you have any questions.

Sparshkhare1306 pushed a commit to Sparshkhare1306/PyGIP-backup that referenced this pull request Oct 1, 2025
create scripts folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants