Clean up

apps/pac-shield-api/src/app/allocation/aircraft-pool.service.spec.ts

@@ -1,6 +1,5 @@
 import { Test, TestingModule } from '@nestjs/testing';
 import { AircraftPoolService } from './aircraft-pool.service';
-import { AllocationNotificationService } from './allocation-notification.service';
 import { PrismaService } from '../../prisma/prisma.service';
 import { GameGateway } from '../../game/game.gateway';
 import { AircraftType } from '@prisma/client';
@@ -20,15 +19,6 @@ const mockPrismaService = {
   },
 } as any;
 
-const mockAllocationNotificationService = {
-  notifyAllocationCycleCreated: jest.fn(),
-  notifyAllocationCycleStatusChanged: jest.fn(),
-  notifyAircraftRequestCreated: jest.fn(),
-  notifyAircraftRequestUpdated: jest.fn(),
-  notifyAircraftAllocated: jest.fn(),
-  notifyAircraftPoolUpdated: jest.fn(),
-};
-
 const mockGameGateway = {
   broadcastAllocationCycleCreated: jest.fn(),
   broadcastAllocationCycleStatusChanged: jest.fn(),
@@ -43,7 +33,6 @@ const mockGameGateway = {
 describe('AircraftPoolService', () => {
   let service: AircraftPoolService;
   let prismaService: any;
-  let allocationNotificationService: any;
   let gameGateway: any;
 
   beforeEach(async () => {
@@ -54,10 +43,6 @@ describe('AircraftPoolService', () => {
           provide: PrismaService,
           useValue: mockPrismaService,
         },
-        {
-          provide: AllocationNotificationService,
-          useValue: mockAllocationNotificationService,
-        },
         {
           provide: GameGateway,
           useValue: mockGameGateway,
@@ -67,7 +52,6 @@ describe('AircraftPoolService', () => {
 
     service = module.get<AircraftPoolService>(AircraftPoolService);
     prismaService = module.get(PrismaService);
-    allocationNotificationService = module.get(AllocationNotificationService);
     gameGateway = module.get(GameGateway);
   });
 

apps/pac-shield-api/src/app/allocation/aircraft-pool.service.ts

@@ -4,7 +4,6 @@ import {
   AircraftPool,
   AircraftType
 } from '@prisma/client';
-import { AllocationNotificationService } from './allocation-notification.service';
 import { GameGateway } from '../../game/game.gateway';
 
 /**
@@ -16,8 +15,6 @@ import { GameGateway } from '../../game/game.gateway';
 export class AircraftPoolService {
   constructor(
     private prisma: PrismaService,
-    @Inject(forwardRef(() => AllocationNotificationService))
-    private allocationNotificationService: AllocationNotificationService,
     @Inject(forwardRef(() => GameGateway))
     private gameGateway: GameGateway
   ) {}
@@ -137,9 +134,6 @@ export class AircraftPoolService {
       newPools.push(pool);
     }
 
-    // Notify about pool updates
-    await this.notifyPoolUpdated(gameId, newPools);
-
     return newPools;
   }
 
@@ -398,31 +392,4 @@ export class AircraftPoolService {
 
     return updatedPools;
   }
-
-  // =============================================
-  //           NOTIFICATION HELPERS
-  // =============================================
-
-  /**
-   * Notify about aircraft pool updates
-   */
-  private async notifyPoolUpdated(gameId: number, pools: AircraftPool[]): Promise<void> {
-    try {
-      const poolStats = pools.reduce((acc, pool) => {
-        acc[pool.aircraftType] = {
-          available: pool.availableCount,
-          allocated: pool.allocatedCount,
-          inTransit: pool.inTransitCount,
-          maintenance: pool.maintenanceCount,
-          total: pool.availableCount + pool.allocatedCount + pool.inTransitCount + pool.maintenanceCount
-        };
-        return acc;
-      }, {} as any);
-
-      await this.allocationNotificationService.notifyAircraftPoolUpdated(gameId, poolStats);
-    } catch (error) {
-      // Log error but don't fail the pool update
-      console.error('Failed to send pool update notification:', error);
-    }
-  }
 }