Skip to content

Maintain a consistent format#4

Open
krvajal wants to merge 3 commits intomasterfrom
feature/code_format
Open

Maintain a consistent format#4
krvajal wants to merge 3 commits intomasterfrom
feature/code_format

Conversation

@krvajal
Copy link
Copy Markdown
Contributor

@krvajal krvajal commented Feb 16, 2019

With this PR I ran clang-format in the whole codebase and added a script to run it easily. It will format the codebase using a consistent style.

I also went ahead and renamed the ugly ArePermutation to is_permutation.
I recommend you to go ahead and adopt this naming convention in which:

  • class methods and standalone functions are names using snake case and
  • classes are named using PascalCase.

The rest I think clang-format takes care of and you dont need to worry about it

@krvajal krvajal requested a review from yurielnf February 16, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant